Thread (13 messages) flat view 13 messages, 6 authors, 2016-06-15

Re: [RFC PATCH 0/2] Allow detached forms (--option arg) for git log options.

From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:49:11

Hi Matthieu,

Matthieu Moy wrote:
                   is there any reason why "git log" hasn't been
migrated to parse-option? Or is it only that nobody did it yet?
Please go ahead. :)

The difficult piece is that the diff and revision handling options are
shared by a large number of commands.

I think my favorite idea is to provide macros to include the
appropriate entries in option tables[1].  Plus side: very easy for
callers to use.  Downside: bloats the option tables, though I think
that can be worked around.

Junio seemed to suggest that adapting the current multi-pass procedure
might be easier[2].

That said, in the meantime, something like this series (just for -S
it would be a big improvement already) would make sense to me.

Thanks.
Jonathan

[1] http://thread.gmane.org/gmane.comp.version-control.git/85354/focus=85391
[2] http://thread.gmane.org/gmane.comp.version-control.git/85354/focus=85362
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help