Thread (19 messages) flat view 19 messages, 4 authors, 2016-06-15

Re: [PATCH 2/6] Makefile: Include subdirectories in "make cover" reports

From: Ævar Arnfjörð Bjarmason <hidden>
Date: 2016-06-15 22:49:10

On Sat, Jul 24, 2010 at 22:37, Thomas Rast [off-list ref] wrote:
Ævar Arnfjörð Bjarmason wrote:
quoted
The buildin/, xdiff/ and compat/ subdirectories weren't being included
in the gcov aggregation, nor were the files there being cleaned up.
[...]
quoted
 coverage-clean:
-     rm -f *.gcda *.gcno
+     $(RM) *.gcov *.gcda *.gcno
+     $(RM) builtin/*.gcov
+     $(RM) builtin/*.gcda
+     $(RM) builtin/*.gcno
By the same logic, the xdiff and compat directories should also be
included here.  Maybe also block-sha1?
Yeah, actually now that I think about it any C code we compile could
spew those *.gcda *.gcno files, which means:

    $ find . -type f -name '*.c'| ack '^(.*/.*)/[^/]+$' --output '$1'|sort|uniq
    ./block-sha1
    ./builtin
    ./compat
    ./compat/fnmatch
    ./compat/nedmalloc
    ./compat/regex
    ./compat/win32
    ./contrib/convert-objects
    ./contrib/examples
    ./contrib/svn-fe
    ./ppc
    ./xdiff

Maybe it would be better to just put:

    *.gcda
    *.gcno

Into .gitignore, and leave it to the user to clean these with git
clean -dxf or something.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help