Thread (77 messages) flat view 77 messages, 4 authors, 2016-06-15

Re: [PATCH 1/8] Export parse_date_basic() to convert a date string to timestamp

From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:49:08

Ramkumar Ramachandra wrote:
approxidate() is not appropriate for reading machine-written dates
because it guesses instead of erroring out on malformed dates.
parse_date() is less convenient since it returns its output as a
string.  So export the underlying function that writes a timestamp.

While at it, change the return value to match the usual convention:
return 0 for success and -1 for failure.
Junio: I think this should be ejected from the series as an
independently useful cleanup.

Currently parse_date_toffset() is exported but not declared anywhere.
This patch gives it a more predictable API and adds a declaration.

Ram: thanks for the reminder.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help