Re: [PATCH] test-lib: simplify GIT_SKIP_TESTS loop
flat view
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:49:06
Subsystem:
the rest · Maintainer:
Linus Torvalds
Possibly related (same subject, not in this thread)
- 2016-06-15 · [PATCH] test-lib: simplify GIT_SKIP_TESTS loop · Michael J Gruber <hidden>
Michael J Gruber [off-list ref] writes:
I am probably making a complete shell fool out of myself by overlooking something completely trivial.
I don't think so. I don't know what the double-loop is trying to achieve myself. We could even lose to_skip variable and the call to test_done inside the case statement, perhaps like this. Thanks. t/test-lib.sh | 13 +++---------- 1 files changed, 3 insertions(+), 10 deletions(-)
diff --git a/t/test-lib.sh b/t/test-lib.sh
index ac496aa..bc06564 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh@@ -385,6 +385,7 @@ test_skip () { case $this_test.$test_count in $skp) to_skip=t + break esac done if test -z "$to_skip" && test -n "$prereq" &&
@@ -829,16 +830,8 @@ this_test=${0##*/} this_test=${this_test%%-*} for skp in $GIT_SKIP_TESTS do - to_skip= - for skp in $GIT_SKIP_TESTS - do - case "$this_test" in - $skp) - to_skip=t - esac - done - case "$to_skip" in - t) + case "$this_test" in + $skp) say_color skip >&3 "skipping test $this_test altogether" say_color skip "skip all tests in $this_test" test_done