Re: [RFC] war on echo in scripts

From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:49:06
Subsystem: the rest · Maintainer: Linus Torvalds

Andreas Schwab wrote:

Jonathan Nieder [off-list ref] writes:

quoted

 die() {
-	echo >&2 "$@"
+	printf >&2 '%s\n' "$@"

You probably want to use "$*" here, though it wouldn't matter for the
uses of die in this file.

Hmm, maybe something like this would be easier.

Signed-off-by: Jonathan Nieder <redacted>
---

diff --git a/git-sh-setup.sh b/git-sh-setup.sh
index 6131670..b38b40b 100644
--- a/git-sh-setup.sh
+++ b/git-sh-setup.sh

@@ -39,6 +39,10 @@ git_broken_path_fix () {
 
 # @@BROKEN_PATH_FIX@@
 
+echo() {
+	printf '%s\n' "$*"
+}
+
 die() {
 	echo >&2 "$@"
 	exit 1

--