Thread (7 messages) flat view 7 messages, 2 authors, 2016-06-15

Re: gitweb.css

From: Eli Barzilay <hidden>
Date: 2016-06-15 22:49:06

On Jul  8, Jakub Narebski wrote:
Eli Barzilay [off-list ref] writes:
quoted
I've been customizing a gitweb server to fit with the rest of our
project pages (the result is http://git.racket-lang.org/).  This was
relatively easy to do except for a few places where gitweb.css
specifies formatting for generic tags like `body', `table', and `td',
which messed up our header.

Maybe it makes sense to localize these styles to to gitweb specific
classes?  (I know that I can just use my own css, but the file is big
enough that I prefer avoiding manually merging in updates.)
Can't you just override gitweb's CSS by your own CSS?  Later CSS
wins.  You can have more than one stylesheet in gitweb
(@stylesheets).
I know -- and I'm using that.  The problem is if there's a property
that we're not defining, then it won't get overridden -- and doing so
requires knowing what the default value is, and keeping our css
updated for future extensions (eg, if tomorrow you make add
`font-family' to the `table' entry, we'll need to add one too, etc).
And still, this means overriding your settings, which were probably
done for a reason...

[...]
I'd rather not add 'gitweb' class (or similar) to every element just
to have common style for all links, tables, table header cells,
table cells.
Why not add just a <div class=".gitweb"> container for all gitweb
content, then have css for ".gitweb foo" for anything you want?

-- 
          ((lambda (x) (x x)) (lambda (x) (x x)))          Eli Barzilay:
                    http://barzilay.org/                   Maze is Life!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help