Re: [PATCH 4/4] Makefile: Don't pass $(ALL_CFLAGS) to the linker

Peter Harris wrote:

The vast majority of git devs work in an environment where compiler
flags and linker flags aren't completely disjoint, and it's not very
polite of us to rework their makefile to fit our view of the world.
Especially when we already have a wrapper that fits their world to
ours.

Yep, good point.

quoted

Also, are you correctly filtering *all* possible inappropriate options?
For example, the very next patch on my branch (not sent to list) adds
a -W3 option ... ;-)

Heck no. This only filters the options that are used by the git makefile.
But adding a filter for -W* is a trivial one liner (one character-er, even).

Your patch fixes my problem, and is *much* better than my patch, so could
you send a formal patch to the list (with W added to the the regex as well
as Z)?

Thanks.

ATB,
Ramsay Jones