Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 3/3] git-instaweb: Don't assume Apache executable is named apache2

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:49:01

Dan McGee [off-list ref] writes:
On Arch Linux, we keep the original 'httpd' name for the exectuable and
don't rename it or the path to the modules.
Sorry, but I cannot parse the last 6 words here.
Remove some of these assumptions
and add the httpd name in where it may be required.
...
 resolve_full_httpd () {
 	case "$httpd" in
-	*apache2*|*lighttpd*)
+	*apache2*|*lighttpd*|*httpd*)
+		# yes, *httpd* covers *lighttpd* above, but it is there for clarity
That may make things work better on Arch but I wonder if there are
platforms that allow users to point at their favorite, non-Apache, http
server with a canonical name "httpd" that gets broken by this change.  Am
I being too paranoid?

Other two patches looked very sane.  Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help