Thread (35 messages) flat view 35 messages, 3 authors, 2016-06-15

Re: [PATCH 3/9] Add memory pool library

From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:49:00

Hi Ram,

Ramkumar Ramachandra wrote:
By marking all the generated functions MAYBE_UNUSED, we're
actually suppressing more warnings than intended. Maybe we can avoid
it and somehow find a way to mark only those functions that are really
unused?
If we used templates instead of macros, a smart compiler would notice
which functions are _never_ used.  But sticking to C, I think it is
fine to rely on humans checking by hand for now.  (FWIW no obj_pool
functions are unused at the moment.)

I tried leaving out the MAYBE_UNUSED for foo_init() before I realized
that calling it is optional.
Perhaps an extra parameter in obj_pool_gen?
Filling out such a list for each caller sounds to me like more trouble
than it’s worth.

Jonathan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help