Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 1/3] t/lib-pager.sh: remove unnecessary '^' from 'expr' regular expression

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:48:59

Brandon Casey [off-list ref] writes:
From: Brandon Casey <redacted>

Regular expressions matched by 'expr' have an implicit '^' at the beginning
of them and so are anchored to the beginning of the string.
Oh, of course; I should have caught this earlier.

$ git grep -n -e 'expr .*: .*['\''"]^'
t/lib-pager.sh:12:if expr "$less" : '^[a-z][a-z]*$' >/dev/null
t/t7005-editor.sh:16:if ! expr "$vi" : '^[a-z]*$' >/dev/null
t/t7006-pager.sh:113:   ! expr "$firstline" : "^[a-zA-Z]" >/dev/null

I'll fix the other two; thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help