Re: [PATCH 2/2 v2] git-gui - provide commit base to the hooks/pre-commit script

On 06/07/2010 10:56 PM, Mark Levedahl wrote:

If hooks/pre-commit acts based upon the changes to be checked in
rather than just the resulting content, the script needs to know which
commit to use. For a normal commit, this is HEAD, but when amending this
is HEAD~1. So, this modifies commit.tcl to pass $1 as HEAD|HEAD~1 depending
upon the commit type. Existing scripts are unaffected as they did not
expect any argument so will silently ignore this extra bit of info.

Signed-off-by: Mark Levedahl<redacted>
   

Given the discussion on the first series  (starting 
with)[ref], and the 
absence of objection to v2, I presume this sequence is ok?

Mark