Re: [PATCH v2 3/3] t/t8006: test textconv support for blame

Le 12 juin 2010 01:52, Junio C Hamano [off-list ref] a écrit :

Axel Bonnet [off-list ref] writes:

quoted

Test the correct functionning of textconv with blame <file> and blame HEAD^ <file>.
Test the case when no driver is specified.

Good to see tests for both positive and negative cases.  Too many people
forget the latter.

quoted

+find_blame() {
+     sed -e 's/^.*(/(/g'
+}

Two issues:

 - No need for "g" as your pattern is anchored at the left;

 - As ".*" is greedy, you will eat a lot more than what you expect when
  the line in the blamed contents happen to have '(' on it.

I'd rewrite it as:

   sed -e 's/^[^(]*//'

Will queue all three patches, with this fix and a style fix for 2/3; no
need to resend.

Thanks.

Thanks. And thanks for fixing.