Re: Misterious warning about file system boundaries [It's a bug, not a mystery.]

On Thu, Jun 10, 2010 at 10:52:40AM +0000, Ævar Arnfjörð Bjarmason wrote:

On Thu, Jun 10, 2010 at 10:36, Michael J Gruber
[off-list ref] wrote:

quoted

I guess we need --I-really-mean-it-refresh.

In fact, not even after recompiling with USE_STDEV=y that
--really-refresh helps which stomps me.But what do I know.

The real problem here is the assumption in 52b98a7 that stat's st_dev
will stay the same for a given device, clearly that's not the case on
Linux if you reboot your machine.

Is there some way of working around that?

We could simply drop the warning. The real point of the original patch
was to stop cross-device traversal in setup_git_directory, which doesn't
care about crossing reboots. I believe the index check and warning are
just there as an early suggestion. When you actually fail to cross the
device boundary looking for .git in the future, it will complain and
mention GIT_DISCOVERY_ACROSS_FILESYSTEM then.

Since the early-warning suggestion is generating false positives, and I
don't think there is a portable and reliable way around it, dropping it
makes sense to me.

-Peff