Re: [PATCH 0/2] Add optional parameters to the diff option "--ignore-submodules"

Hi,

On Tue, 8 Jun 2010, Junio C Hamano wrote:

Johannes Schindelin [off-list ref] writes:

quoted

I agree that the basic reason for the default to check for dirty and 
untracked files is sound.

It is not your (Jens') fault that this does not integrate well into the 
Git context, and that users of the submodule feature were punished that 
heavily (just to reiterate, if anybody missed that number, the time on 
"git status" -- or for that matter, "git diff" -- went up by >4500%. In 
English words, that is four-thousand five hundred percent, and that is 
just a lower bound).

So I would actually argue (being a real submodule user, not just an 
imaginary one) that the default for dirty checking in the submodules 
should stay.

Let me make sure I understand.  You repeated three times that you suffered
big time spending too many cycles due to extra checks (compared with older
behaviour of not checking submodule working tree at all), but you would
recommend the default to be the expensive one?

I also pointed out that the suffering came from power usage of submodules.

If you only have a handful of submodules, and if they are relatively 
small, the current default makes much more sense than 
--ignore-submodules=dirty

Hth,
Johannes