Re: [RFC/PATCH 1/4] gitweb: Move subroutines to Gitweb::Config module

On Wed, Jun 9, 2010 at 1:25 AM, Petr Baudis [off-list ref] wrote:

On Wed, Jun 09, 2010 at 12:52:11AM +0530, Pavan Kumar Sunkara wrote:

quoted

I am graining Gitweb::HTML into Gitweb::HTML::* to reduce circular
dependancies of the modules.

I'm sorry, I don't understand. How is splitting up Gitweb::HTML to
submodules helping to reduce circular dependencies? I don't quite see
that right now. :-( Can you give a concrete example? Perhaps it would be
better to refactor the few problematic users instead of convoluting the
whole module structure because of the offenders.

Ok. I will be combining them into a single module.

quoted

  Gitweb::Parse

What will this module do?

This module contains all the parse_* subroutines

Gitweb::Format contains all the format_* subroutines

quoted

  Gitweb::Util

What will this module do?

This modules contains all the git utility functions.

quoted

  Gitweb::Action::* (All action subs like git_blame, git_log)

Do we need to do this right now? I think moving huge chunks of the code
around like this right now is unneccessary and it might just enlarge the
patch queue and delay you in your main GSoC efforts; perhaps we could do
this later when the dust settles a bit and we are sure that the rest of
the modular structure we have introduced fits well?

I still have until this week in the timeline. Don't I ?
I strongly hope that I will be able to finalise the patch queue by
this week and will move on to develop write functionalities.

Thanks,
Pavan.