Thread (31 messages) flat view 31 messages, 5 authors, 2016-06-15

Re: [PATCH v5 05/18] Do not use "diff" found on PATH while building and installing

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:48:53

"Gary V. Vaughan" [off-list ref] writes:
quoted hunk ↗ jump to hunk
Index: b/Documentation/install-webdoc.sh
===================================================================
--- a/Documentation/install-webdoc.sh
+++ b/Documentation/install-webdoc.sh
@@ -12,7 +12,7 @@ do
 	then
 		: did not match
 	elif test -f "$T/$h" &&
-	   diff -u -I'Last updated [0-9][0-9]-[A-Z][a-z][a-z]-' "$T/$h" "$h"
+	   $DIFF -u -I'Last updated [0-9][0-9]-[A-Z][a-z][a-z]-' "$T/$h" "$h"
Do we or do we not want to quote "$DIFF"?  iow, how well do we deal with $IFS
whitespace in the path?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help