Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH v2] gitk: Show notes by default (like git log do)

From: Paul Mackerras <hidden>
Date: 2016-06-15 22:48:52

On Thu, May 20, 2010 at 01:50:41PM +0400, Kirill Smelkov wrote:
Starting from ~ git-1.6.6, log, show & whatchanged show notes by default.

On the other hand, gitk does not show notes by default, because under
the hood it calls `git log --pretty=raw ...` to get the log, and in
`git log` notes are turned off, when user specifies format or pretty
settings.

Yes, it is possible to invoke `gitk --show-notes` explicitly, but since
from user's perspective, gitk is gui enabled git log, it would be
logical for gitk to show notes by default too for consistency.

In git, --show-notes was introduced in 66b2ed (Fix "log" family not to
be too agressive about showing notes) which predates 1.6.6.2

Notes can still be supressed with `gitk --no-notes`.

Cc: Michael J Gruber <redacted>
Signed-off-by: Kirill Smelkov <redacted>
Thanks, applied.

Paul.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help