Re: Apology/Bug report: git-send-email sends everything on Ctrl+C
From: Sam Vilain <hidden>
Date: 2016-06-15 22:48:51
Subsystem:
documentation, the rest · Maintainers:
Jonathan Corbet, Linus Torvalds
Michael J Gruber wrote:
quoted
quoted
Hard to know what could have possibly stopped this from happening. PEBKAC.Perhaps git can be smart and ask for confirmation for huge (>20 ?) patchsets.to be overriden by an option "--no-villain"... Sorry, bad joke, but couldn't resist. Feel free to pick on my name ;)
I went with the simpler and pre-existing --confirm=never :-) Subject: [PATCH] send-email: confirm for really large patch sets It is possible to send a lot of e-mails using quite simple user errors with git send-email; if they were not intended this could be quite a lot of spam. Ask a final question if there are a lot of messages before sending. Signed-off-by: Sam Vilain <redacted> --- untested: after what just happens there is no way I'm testing this :-) git-send-email.perl | 13 +++++++++++++ 1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt
index 12622fc..093b7f2 100644
--- a/Documentation/git-send-email.txt
+++ b/Documentation/git-send-email.txt@@ -257,6 +257,11 @@ Administering Default is the value of 'sendemail.confirm' configuration value; if that is unspecified, default to 'auto' unless any of the suppress options have been specified, in which case default to 'compose'. ++ +If you are sending a very large patch sequence (more than 20 parts), +you will be asked for a second final confirmation before anything is +sent. This can be suppressed by setting this configuration value to +'never'. --dry-run:: Do everything except actually send the emails.
diff --git a/git-send-email.perl b/git-send-email.perl
index 111c981..2775506 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl@@ -1096,6 +1096,19 @@ $references = $initial_reply_to || ''; $subject = $initial_subject; $message_num = 0; +if ($needs_confirm ne "never" and @files > 20) { + $_ = ask( + "That's a big patch set - ".@files." parts. " + ."Are you sure you want to do this? ([y]es|[n]o): ", + valid_re => qr/^(?:yes|y|no|n)/i, + default => "n", + ); + if (/^n/i) { + cleanup_compose_files(); + exit(0); + } +} + foreach my $t (@files) { open(F,"<",$t) or die "can't open file $t";
--
1.7.1.rc2.333.gb2668