Thread (17 messages) flat view 17 messages, 3 authors, 2016-06-15

Re: [PATCH 3/3] commit: show abbreviated sha for commits with empty diffs

From: Tay Ray Chuan <hidden>
Date: 2016-06-15 22:48:51

Hi,

On Wed, May 26, 2010 at 1:07 PM, Junio C Hamano [off-list ref] wrote:
The fix itself might be trivial, but the series seems to break 7502.20
and 7502.22
I tested this patch series on top of:

 - efd1311 (Merge branch 'jn/shortlog' into next), which contains
   c197702 (pretty: Respect --abbrev option), the first offending commit
   to print un-abbreviated SHA-1s.

 - b26ba11, the recent 'next'.

It both cases, #20 and #22 passed fine.

Also, I outlined another possible fix in the cover letter to this
series:

  1274694452-4200-1-git-send-email-rctay89@gmail.com
  http://thread.gmane.org/gmane.comp.version-control.git/147619

I find the alternative fix a bit more precise; I'd appreciate your
comments, if you get the chance.

-- 
Cheers,
Ray Chuan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help