Re: [RFC PATCH] GIT-VERSION-GEN: restrict tags used

Tay Ray Chuan wrote:

Restrict the tags used to generate the version string to those that
begin with "v"

I like it.  Thanks!

since git's tags for git-core (ie. excluding git-gui)
are all of the form "vX.Y...".

git gui’s too, now.

This is to avoid using private tags by the user in a clone of the git
code repository, which may break certain machinery (eg. Makefile).

Not to mention gitk:

  set git_version [join [lrange [split [lindex [exec git version] end] .] 0 2] .]
  if {[package vcompare $git_version "1.6.1"] >= 0} {

This requires ‘git version’ output to have the form

  introducing 1.2.3.otherstuff

or there will be errors at startup time.

  After this patch, perhaps we could advertise somewhere to git hackers
  that tags beginning with "v" should be avoided.

Maybe v[0-9]* would make this problem harder to trip.

Jonathan