Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] cherry-pick: do not dump core when iconv fails

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:48:46

Jonathan Nieder [off-list ref] writes:
When cherry-picking, usually the new and old commit encodings are both
UTF-8.  Most old iconv implementations do not support this trivial
conversion, so on old platforms, out->message remains NULL, and later
attempts to read it segfault.
This agrees with what builtin/commit.c does around ll.896; even if the
encoding pair says "utf8" and "UTF-8", we would do the right thing.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help