Re: git diff too slow for a file

René Scharfe [off-list ref] writes:

But when I take a closer look at the surrounding code, I can't help but
ask if the flags really have be passed in such a complicated way.

How about the following, which makes xdi_diff*() take a simple flag
parameter instead, moving the code to handle xpparam_t into
xdiff-interface.c, which seems to be the proper place for it?

This looks very sensible.  Your patch doesn't touch xdiff/ proper but only
the thin interface layer, so we don't have to worry about deviating from
the upstream even further.