Thread (1 message) 1 message, 1 author, 2016-06-15

Re: Global .git directory

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:48:45

Andrew Ruder [off-list ref] writes:
I'm not really a person that will be doing the reviewing but as a
frequent lurker on the list, I'm going to try to help you out some.
Thanks.
While you're not exactly fixing a bug, this would benefit from a
testcase.
Just so that people do not misunderstand.  A test is _not_ about proving
that your patch fixed a bug.  It instead is to protect your change from
future breakages by _other people_.

Having a test that would fail if careless others muck with related
codepath in the future without taking your change into account is a good
way to make sure your new feature or your good change of behaviour keep
working (the alternative is for you as the author of such a valuable
change to stay on the list 24/7, audit all the patches that may negatively
affect your change and veto them before they are applied, which is
impractical for most people).
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help