Re: Global .git directory

On Wed, Apr 28, 2010 at 7:33 AM, Gerhard Wiesinger [off-list ref] wrote:

On Tue, 27 Apr 2010, Erik Faye-Lund wrote:

quoted

On Tue, Apr 27, 2010 at 10:06 PM, Gerhard Wiesinger [off-list ref]
wrote:

quoted

On Tue, 27 Apr 2010, Thomas Rast wrote:

quoted

(In other words, please convince us that this is actually worth
having.)

Ok, rather than convincing I've written a (fast) patch which works for me
:-)

Any comments? Any (further) changes needed? Will you include it in main
git?

Please see Documentation/SubmittingPatches. It's difficult to comment
on a non-inlined patch.

Patch done on top of HEAD.
git format-patch -M origin/master
0001-Added-global-git-directory-when-environment-variable.patch
0002-Added-global-git-directory-when-environment-variable.patch
0003-Updated-documentation-for-submitting-patches.patch
Attached.

I was referring to that you sent the patch attached instead of inlined
(as Documentation/SubmittingPatches suggests).

By attaching patches you force everyone who wants to review the patch
to have to copy and manually quote the parts of the patch that they
have comments about instead of automatic quoting like all decent
e-mail clients do. That way you get less people interested in the
patch.

I sent this reply because you did the right thing of cooking up a
patch in the first place (as opposed to just arguing - very good), so
I think you deserve a chance of getting the patch reviewed (and
possibly included... if people agree with you, that is).

-- 
Erik "kusma" Faye-Lund