Thread (27 messages) flat view 27 messages, 3 authors, 2016-06-15

Re: [PATCH v2 1/3] pretty: add conditional %C?colorname placeholders

From: Jeff King <hidden>
Date: 2016-06-15 22:48:42

On Sun, Apr 25, 2010 at 11:14:12PM -0500, Jonathan Nieder wrote:
quoted
%C(diff.commit), we are not breaking anything (because it is a new
syntax), but a script like the one above may want to convert, and there
is no way to say "respect the color _config_, but don't respect
isatty(1)". Saying "--color" doesn't work, because it overrides the
color config. We can cheat a little with GIT_PAGER_IN_USE, but that will
have funny interactions with pager.color.
Very interesting.  I think the natural solution (for new colors) would
be a --color=config option, which would require parsing options before
checking configuration.

Does this sound sane?
Yeah, that makes sense to me.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help