Re: [PATCH 1/3] pretty: add conditional %C?colorname placeholders

On Mon, Apr 26, 2010 at 7:30 AM, Alex Riesen [off-list ref] wrote:

On Sun, Apr 25, 2010 at 17:42, Will Palmer [off-list ref] wrote:

quoted

diff --git a/Documentation/pretty-formats.txt b/Documentation/pretty-formats.txt
index 1686a54..53eb903 100644
--- a/Documentation/pretty-formats.txt
+++ b/Documentation/pretty-formats.txt

@@ -132,6 +132,7 @@ The placeholders are:

 - '%Cblue': switch color to blue
 - '%Creset': reset color
 - '%C(...)': color specification, as described in color.branch.* config option
+- '%C?...: switch to specified color, if relevant color.* config option specifies that color is ok

You missed the closing quote character. Besides, how do you think to
distinguish between "%C?diff.color" and "%C?diff.colorcontinuation text"?
The "%C(...)" has a placeholde termination rule (the closing bracket), yours
does not seem to have one (unless something is missing in the documentation).

Ah... I see. Definitely something missing. The spec should be: '%C?(...)'.

It's meant to handle both %C?green and %C?(green), perhaps I should
list those out on separate lines?
Missing quote noted, thanks.