Re: CIA hook for contrib/

Petr Baudis [off-list ref]:

On Sat, Mar 27, 2010 at 06:26:32AM -0400, Eric Raymond wrote:

quoted

Upon investigating further, I find that ciabot.sh seems to be a
derivative of ciabot.pl, which is a dangling bit of the moribund
Cogito project.  I have been unable to get responses from the authors
of either ciabot.sh or ciabot.pl.

  Strange, I received no mail from you. When did you send it?

About three weeks ago now.  Sorry, it appears I fat-fingered your
address.  I did eventually hear from the author of the 2008 sh
version; he passed me the maintainer's baton on that one.
 

  I'm happy that someone resurrected the hook script, thanks for that!
By the way, you seem to drop support for XML::RPC altogether while the
original ciabot.pl could use both. While XML::RPC requires another
dependency (not sure if plain Python installation can do it) and it can
time out in case of CIA server trouble (not sure how common these are
nowadays), the distinct advantage is that the commits will always end up
in correct order, while it seemed to be common that by mail, push of
multiple commits would reorder them randomly.

Ah, I did not know of that advantage, it wasn't documented anywhere.
It's a sufficient reason to bring back XML-RPC support...and I
have just done so in the Python version.

quoted

# update: You have to call it once per merged commit:
#
#       refname=$1
#       oldhead=$2
#       newhead=$3
#       for merged in $(git rev-list ${oldhead}..${newhead} | tac) ; do
#               /path/to/ciabot.bash ${refname} ${merged}

                  ^^^^^^^^^^^^^^^^^^^^

Obsolete .bash reference.

Fixed, thanks.

I personally find git-describe'd revspecs extremely ugly, unreadable and
less practical than plain hex ids (maybe I'm weird?), it would be really
nice to get a configuration choice between git describe and just:

	rev=$(echo "$merged" | cut -c 1-12)

(Not sure about the bashism rant since you can trivially just replace it
with the cut.)

Good point about use of cut; I'll do that.  

I've implemented a revformat variable, but defaulted it to 'describe'.
 

I would personally prefer to have this configurable; I consider trying
to protect your e-mail address against harvesters is a lost fight anyway
and you'd be much better off just getting a good spam filter, rather
than making yours and others' life harder by trying to fight in vain.
But it's not too important for me since I can just disable this easily.

But email name collisions within projects are vanishingly rare, so I
don't see a lot of benefit in publishing the FQDN.
 

Your life would be much easier in both the shell and python script if
you used something like:

	git log -1 '--pretty=format:%an <%ae>%n%at%n%s'

You would also get <ts> in the correct format, incl. timezone correction.

Good point.  I inherited that nasty code; perhaps this facility did not
exist when it was written.
-- 
		<a href="http://www.catb.org/~esr/">Eric S. Raymond</a>