Re: [PATCH] remote add: add a --no-tags (-n) option

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:48:40

Samuel Tardieu [off-list ref] writes:

quoted hunk

@@ -116,6 +116,8 @@ static int add(int argc, const char **argv)
 
 	struct option options[] = {
 		OPT_BOOLEAN('f', "fetch", &fetch, "fetch the remote branches"),
+		OPT_BOOLEAN('n', "no-tags", &notags,
+			"do not import remote tags when fetching"),

Any long-opt that begins with "no-" looks wrong, especially that will
allow people to say "--no-no-tags".  Perhaps something like this is
necessary.

    { OPTION_BOOLEAN, 0, "tags", &tags, NULL, "fetch tags", PARSE_OPT_NOARG }

Or imitate whatever we do in builtin-fetch.c; although I suspect the
default would be different in this command and "git fetch", so you may
need to adjust for the difference a bit.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help