Thread (5 messages) flat view 5 messages, 3 authors, 2016-06-15

Re: git pull with "no common commits" : danger?

From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:48:34

Hi,

Aghiles wrote:
I mistakenly pulled a project into another project. I had the
"warning: no common commits" but the pull did proceed.
First: you are aware that interrupting the pull will have no bad
side-effects, right?  So if the worry is lost time, then git is not
advertising its features well enough.

Because of this, if ‘git fetch’ starts refusing to fetch when there
are no common commits, I will be unhappy, because it imposes hassle on
the user for basically no benefit.

On the other hand, ‘git pull’ is a little different.  The fetch has
very little cost because it’s interruptible, but the merge could
result in two unrelated pieces of history being merged, requiring
the user to use ‘git reset --keep HEAD^’ to get back to the
previous state.  A more likely outcome is a merge conflict, requiring
‘git reset --merge’ to recover.

Can we make this less painful?  Is it worth adding yet another option
to ‘git pull’ to avoid this pain?  I don’t know.

Regards,
Jonathan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help