Thread (12 messages) flat view 12 messages, 6 authors, 2016-06-15

Re: [PATCH/RFC] gitk: refresh index before checking for local changes

From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:48:34 

Hi,

I’ll start off the reviewing, too:

Jonathan Nieder wrote:

+    if {![eof $fd]} {
+        return 1
Whitespace damage.
quoted hunk ↗ jump to hunk
@@ -7504,13 +7540,9 @@ proc getblobdiffs {ids} {
     global git_version
 
     set textconv {}
-    if {[package vcompare $git_version "1.6.1"] >= 0} {
-	set textconv "--textconv"
-    }
+    set textconv "--textconv"
     set submodule {}
-    if {[package vcompare $git_version "1.6.6"] >= 0} {
-	set submodule "--submodule"
-    }
+    set submodule "--submodule"
     set cmd [diffcmd $ids "-p $textconv $submodule  -C --cc --no-commit-id -U$diffcontext"]
     if {$ignorespace} {
 	append cmd " -w"
What does this have to do with the topic at hand?  (Sorry, I lumped
in a local fix that still needs to be generalized and submitted
separately.)

So this patch is in good enough shape to try out, but please ping me
for a new one before it is time to send something like it on to the
masses.

Sorry for the noise,
Jonathan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help