Re: [PATCH] Makefile: move -Wall from CFLAGS to BASIC_CFLAGS
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:48:33
Matt McCutchen [off-list ref] writes:
-Wall cleanliness is an intended property of the codebase, so -Wall should be on by default even if the user's CFLAGS doesn't include it (e.g., the AC_PROG_CC configure test won't include it). --- Thoughts? Is there a problem with -Wall being GNU-specific?
I think you answered yourself very well.
quoted hunk
@@ -308,7 +308,7 @@ SPARSE_FLAGS = -D__BIG_ENDIAN__ -D__powerpc__ # Those must not be GNU-specific; they are shared with perl/ which may # be built by a different compiler. (Note that this is an artifact now # but it still might be nice to keep that distinction.) -BASIC_CFLAGS = -I. +BASIC_CFLAGS = -Wall -I. BASIC_LDFLAGS =
It still talks about perl/ back from the days when we used to have some .xs stuff, but the principle still should apply.