Re: nd/setup

On Sat, Apr 3, 2010 at 7:00 AM, Jonathan Nieder [off-list ref] wrote:

Nguyen Thai Ngoc Duy wrote:

quoted

I haven't forgotten the "git init" with alias bug Jonathan found. Just
a little busy with other stuff.

You already fixed it, I think. ;-)

Hmm.. so I do forget something. I still miss some of your good tests though.

-- %< --
Subject: Revert "help: use RUN_SETUP_GENTLY"

Commit 717b8850580ecb9009505f71ea43ecda51ac1f0e taught ‘git help’
to unconditionally looks for a git directory, with the justification:

   So the sooner we set up gitdir, the less trouble we may have to
   deal with.

In the case of ‘git help -a’, that is not quite true.  In automount
setups like that which prompted v1.6.0-rc0~121^2~1 (Add support for
GIT_CEILING_DIRECTORIES, 2008-05-19), if GIT_CEILING_DIRECTORIES is
unset, then probing for the Git directory can take a long time.  Thus
unnecessarily searching for a git directory can slow down ‘git help -a’
(and thus bash completion).

‘git help’ does not use RUN_SETUP or USE_PAGER, and neither option
parsing nor producing output for plain ‘git help’ or ‘git help -a’
requires access to the git configuration.  Therefore it is safe to not
search for the git directory early in this case.

Also add some comments to document the requirements this places on
list_commands() and list_common_cmds_help().

Signed-off-by: Jonathan Nieder <redacted>

Didn't notice it. Looks good. I will replace the "help: use
RUN_SETUP_GENTLY" commit with this patch next time, if you don't mind.
-- 
Duy