Re: CIA hook for contrib/
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:48:31
Eric Raymond [off-list ref] writes:
Summary: * The CIA hooks for git are presently dusty and somewhat broken.
Thanks; but I don't ship any ancient hooks, so this probably wants to be sent to whoever still have them displayed on their sites.
* I am requesting that they be given a home in git contrib/.
I gave a quick read to the shell one, and I found it reasonable. Thanks for sharing. One tiny nit is the "git --exec-path" bit, though. You don't seem to use any ancient "git-frotz" form, so it is not just unnecessary but is misleading. I'd recommend to just drop it. Another tiny nit is that you _might_ want to make it fail loudly if somebody copies this out of contrib/ without changing $project properly, instead of spamming cia with bogus messages claiming that they pertain to the GPSD project.
I am also enclosing a rewrite in Python. This has a serious functional advantage over either Perl or sh; the batteries-included effect of the Python libraries means it's not dependent on things like the path location of sendmail or whether the hosting site will allow it to run wget. ... Code is enclosed.
Thanks. Could you send a signed-off patch that creates contrib/ciabot/ directory, and places these two files in there, with a README describing that you are the maintainer of these tools?