Thread (14 messages) flat view 14 messages, 6 authors, 2016-06-15
STALE3737d

[PATCH] rev-list: heed --abbrev-commit option

From: Michael J Gruber <hidden>
Date: 2016-06-15 22:48:28
Subsystem: the rest · Maintainer: Linus Torvalds

Currently, rev-list has a default of "0" for abbrev which means that
switching on abbreviations with --abbrev-commit has no visible effect,
even though the option is documented.

Set abbrev to DEFAULT_ABBREV so that --abbrev-commit has the same effect
as for log.

Signed-off-by: Michael J Gruber <redacted>
Reported-by: Eli Barzilay <redacted>
---
I'm actually wondering why log and rev-list don't share the relevant
part of that code.

 builtin/rev-list.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/builtin/rev-list.c b/builtin/rev-list.c
index 5679170..eb8e2c2 100644
--- a/builtin/rev-list.c
+++ b/builtin/rev-list.c
@@ -313,7 +313,7 @@ int cmd_rev_list(int argc, const char **argv, const char *prefix)
 
 	git_config(git_default_config, NULL);
 	init_revisions(&revs, prefix);
-	revs.abbrev = 0;
+	revs.abbrev = DEFAULT_ABBREV;
 	revs.commit_format = CMIT_FMT_UNSPECIFIED;
 	argc = setup_revisions(argc, argv, &revs, NULL);
 
-- 
1.7.0.3.435.g097f4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help