Re: [PATCH] Makefile: Fix CDPATH problem

Jonathan Nieder [off-list ref] writes:

CDPATH takes scripts to unexpected places.  For example, with a CDPATH
including a blt directory:

 make -C templates DESTDIR='' install
 make[1]: Entering directory `/users/e477610/exptool/src/git-1.7.0.2/templates'
 install -d -m 755 '/home/e477610/exptool/share/git-core/templates'
 (cd blt && gtar cf - .) | \
	(cd '/home/e477610/exptool/share/git-core/templates' && umask 022 && gtar xof -)
 gtar: This does not look like a tar archive

The CDPATH mechanism does not implicitly add "." at the beginning of
CDPATH, which is the most irritating part.

Most git scripts already protect against use of CDPATH through
git-sh-setup, but the Makefile doesn’t.

Eh, the rationale and the in-code comment need to be fixed.  The issue is
not "taking us to random places", but "reporting the name of the random
place in its standard output".

But other than that, this is something we have seen on the list a few
times, and I think it is about time to do this.

Thanks.