Re: [PATCH] Add ignore and clean rules for gitweb.min.js
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:48:27
Mark Rada [off-list ref] writes:
Signed-off-by: Mark Rada <redacted>
Thanks; one question and a comment.
quoted hunk
--- .gitignore | 1 + Makefile | 3 +++ 2 files changed, 4 insertions(+), 0 deletions(-)diff --git a/.gitignore b/.gitignore index 7b3acb7..3558dd2 100644 --- a/.gitignore +++ b/.gitignore@@ -156,6 +156,7 @@ /git-core-*/?* /gitk-git/gitk-wish /gitweb/gitweb.cgi +/gitweb/gitweb.min.js /test-chmtime /test-ctype /test-date
Question: should this be part of your earlier "instaweb" patch, or are they independent?
quoted hunk
diff --git a/Makefile b/Makefile index f80b25e..cdf16c2 100644 --- a/Makefile +++ b/Makefile@@ -2078,6 +2078,9 @@ clean: $(MAKE) -C Documentation/ clean ifndef NO_PERL $(RM) gitweb/gitweb.cgi +ifdef JSMIN + $(RM) gitweb/gitweb.min.js +endif #JSMIN $(MAKE) -C perl clean endif
Running "make clean" in perl/ should stay in "ifndef NO_PERL", but I think
removal of both gitweb/{gitweb.cgi,gitweb.min.js} should be unconditional;
it does not hurt as $(RM) is "rm -f" (i.e. don't complain to ENOENT).