[PATCH 0/9] Multiple remotes without conflicts · Andreas Gruenbacher <hidden> · 2016-06-15
[PATCH 1/9] fetch: Check for a "^{}" suffix with suffixcmp() · Andreas Gruenbacher <hidden> · 2016-06-15
[PATCH 2/9] fetch: Properly initialize refspec on stack · Andreas Gruenbacher <hidden> · 2016-06-15
[PATCH 3/9] fetch: Fix minor memory leak · Andreas Gruenbacher <hidden> · 2016-06-15
[PATCH 4/9] fetch: Move deepening fetch check into builtin/fetch.c · Andreas Gruenbacher <hidden> · 2016-06-15
[PATCH 5/9] fetch: Move loop checking which refs we have already · Andreas Gruenbacher <hidden> · 2016-06-15
[PATCH 6/9] fetch: Check if all objects exist after fetching · Andreas Gruenbacher <hidden> · 2016-06-15
[PATCH 7/9] fetch: Use the same ref map for all branches and tags · Andreas Gruenbacher <hidden> · 2016-06-15
[PATCH 8/9] fetch: Don't fetch tags twice · Andreas Gruenbacher <hidden> · 2016-06-15
[PATCH 9/9] fetch: Make automatic tag following work with arbitrary refspecs · Andreas Gruenbacher <hidden> · 2016-06-15
Re: [PATCH 6/9] fetch: Check if all objects exist after fetching · Shawn O. Pearce <hidden> · 2016-06-15
Re: [PATCH 6/9] fetch: Check if all objects exist after fetching · Andreas Gruenbacher <hidden> · 2016-06-15
Re: [PATCH 0/9] Multiple remotes without conflicts · Shawn O. Pearce <hidden> · 2016-06-15
Re: [PATCH 0/9] Multiple remotes without conflicts · Andreas Gruenbacher <hidden> · 2016-06-15

DORMANTno replies

[PATCH 3/9] fetch: Fix minor memory leak

From: Andreas Gruenbacher <hidden>
Date: 2016-06-15 22:48:27
Subsystem: the rest · Maintainer: Linus Torvalds

A temporary struct ref is allocated in store_updated_refs() but not
freed.

Signed-off-by: Andreas Gruenbacher <redacted>
---
 builtin/fetch.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/builtin/fetch.c b/builtin/fetch.c
index 660af84..957be9f 100644
--- a/builtin/fetch.c
+++ b/builtin/fetch.c

@@ -389,9 +389,10 @@ static int store_updated_refs(const char *raw_url, const char *remote_name,
 				fputc(url[i], fp);
 		fputc('\n', fp);
 
-		if (ref)
+		if (ref) {
 			rc |= update_local_ref(ref, what, note);
-		else
+			free(ref);
+		} else
 			sprintf(note, "* %-*s %-*s -> FETCH_HEAD",
 				TRANSPORT_SUMMARY_WIDTH, *kind ? kind : "branch",
 				 REFCOL_WIDTH, *what ? what : "HEAD");

-- 
1.7.0.2.273.gc2413