This says "if 'editor' is not exactly the string ':'", ...
Oh right; I ... yeah, something. (I've got no excuse for mis-thinking
that one.)
If you end up with a file whose name literally is '$@', that probably
means your "sh" did not expand it correctly.
It does expand the $@ when I add it explicitly to core.editor though. Maybe
it's the ""s. I'll have to figure out how to compile git for Windows
to try a patch.
Oddly enough, if I remove the : from the file path, it does work as
expected. Adding the : back introduces the faulty behavior described
earlier.
Tait