Thread (13 messages) flat view 13 messages, 5 authors, 2016-06-15

Re: Re: [PATCH] git-gui: fix "Explore Working Copy" for Windows again

From: Heiko Voigt <hidden>
Date: 2016-06-15 22:48:22

On Fri, Feb 26, 2010 at 01:46:05AM +0100, Johannes Schindelin wrote:
On Thu, 25 Feb 2010, Heiko Voigt wrote:
quoted
On Thu, Feb 25, 2010 at 01:14:22AM +0100, Markus Heidelberg wrote:
quoted
It has already been fixed in commit 454efb47 (git-gui (Win): make
"Explore Working Copy" more robust, 2009-04-01), but has been broken in
commit 21985a11 (git-gui: handle non-standard worktree locations,
2010-01-23) by accidentally replacing too much with a new variable.

The problem can be reproduced when starting git-gui from within a
subdirectory. The solution is to convert the path name, explorer.exe is
invoked with, to a platform native name.

Signed-off-by: Markus Heidelberg <redacted>
---
I can confirm that this does fix the issue which is actually also 
apparent on Windows XP. If no objections occur I would apply this to the 
devel branch for msysgit.
No objections from my side!
Done.

cheers Heiko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help