Re: [PATCHv4 6/6] is_submodule_modified(): clear environment properly
From: Johannes Sixt <hidden>
Date: 2016-06-15 22:48:20
From: Johannes Sixt <hidden>
Date: 2016-06-15 22:48:20
Giuseppe Bilotta schrieb:
+ const char *env[local_repo_env_size+2];
Variable sized arrays are prohibited.
struct strbuf buf = STRBUF_INIT; + /* Copy local_repo_env to env, letting i + rest at the last NULL */ + while (env[i] = local_repo_env[i]) + ++i; /* do nothing */ +
This looks very inconsistent: At the one hand, you use l_r_e_size to allocate the space, but then you iterate over it assuming that the list is (also) NULL-terminated. But this is only a minor nit. -- Hannes