Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] fix threaded grep for machines with only one cpu

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:48:17

Junio C Hamano [off-list ref] writes:
Heiko Voigt [off-list ref] writes:
quoted
In case the machine has only one cpu the initialization was
skipped.
An obvious question that forces reviewers to go "Huh?" is why this
matters.

If use_threads is false, we do not call start_threads(), and I think at
least the intent of the threaded grep code in 5b594f4 (Threaded grep,
2010-01-25) is that uninitialized mutexes matter at all in that case.
s/matter/do not &/; obviously.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help