Re: [PATCH 3/4] git-am: Add command line parameter `--keep-cr` passing it to git-mailsplit.

"Stefan-W. Hahn" [off-list ref] writes:

Also sprach Junio C Hamano am Thu, 11 Feb 2010 at 15:21:32 -0800:

quoted

"Stefan-W. Hahn" [off-list ref] writes:

quoted

If applying patches with the following command sequence

   git format-patch --stdout ... | git am ...

in repositories having files with dos and unix line endings
git-mailsplit, which is called from git-am must be called with
`--keep-cr` parameter since commit c2ca1d79.

Sorry, I cannot parse this.

What?

What I said.  I wasn't able to parse it.  If it were:

    If applying patches with the following command sequence

       git format-patch --stdout ... | git am ...

    in repositories having files with dos and unix line endings,
    git-mailsplit, which is called from git-am, must be called with
    `--keep-cr` parameter since commit c2ca1d79.

iow, two additional commas, I would have been able to, but I was not
certain that is what you meant.

quoted

quoted

+e,keep-cr       pass --keep-cr flag to git-mailsplit for mbox format

This short form -e does not make much sense to me.  Why is it -e, and do
we even need a short form in the first place?

Just for shortening the commandline.

That much I know already ;-) and you probably know that I knew when I
wrote this, which you somehow omitted from your quote:

    ... We may want to use short-and-sweet 'e' for something more
    important and common, and we would regret for letting this option
    squat on it later.

The shorter one can come later after people find --keep-cr is something
they often need to use and deserve a shorter form, but not until then.