Re: [PATCH] blame: prevent a segv when -L given start > EOF

On Tue, Feb 9, 2010 at 2:43 AM, Johannes Sixt [off-list ref] wrote:

Jay Soffian schrieb:

quoted

+test_expect_success 'blame -L with invalid start' '
+     test_must_fail git blame -L5 tres 2>&1 | grep "has only 2 lines"

Please write this as

       test_must_fail git blame -L5 tres >output 2>&1 &&
       grep "has only 2 lines" output

quoted

+'
+
+test_expect_success 'blame -L with invalid end' '
+     git blame -L1,5 tres 2>&1 | grep "has only 2 lines"

       test_must_fail git blame -L1,5 tres >output 2>&1 &&
       grep "has only 2 lines" output

because shells look only at the exit code of the last command in a pipeline.

Thanks, I knew that. I'd left in test_must_fail accidentally because
initially I wasn't bothering to grep the output. I then added the grep
and forgot to remove test_must_fail. Isn't this an adequate test:

  test_expect_success 'blame -L with invalid start' '
     git blame -L5 tres 2>&1 | grep "has only 2 lines"

As it seems unlikely git would crash and still output the message
correctly in this case.

?

j.