Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] blame: prevent a segv when -L given start > EOF

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:48:12

Junio C Hamano [off-list ref] writes:
Jay Soffian [off-list ref] writes:
quoted
-	if (lno < top)
+	if (lno < top || lno < bottom)
 		die("file %s has only %lu lines", path, lno);
Thanks; I think we make sure that "bottom < top" always hold true before
we reach this point, so checking with bottom alone should suffice, no?
I am ... stupid.  If lno < bottom, then lno < top, but we need to check
both anyway.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help