Thread (4 messages) flat view 4 messages, 2 authors, 2016-06-15

Re: [PATCH] blame: prevent a segv when -L given start > EOF

From: Jay Soffian <hidden>
Date: 2016-06-15 22:48:12

On Mon, Feb 8, 2010 at 10:55 PM, Junio C Hamano [off-list ref] wrote:
Jay Soffian [off-list ref] writes:
quoted
-     if (lno < top)
+     if (lno < top || lno < bottom)
              die("file %s has only %lu lines", path, lno);
Thanks; I think we make sure that "bottom < top" always hold true before
we reach this point,
We swap them if they're reversed.
so checking with bottom alone should suffice, no?
Ah true. You can squash that in? :-)

j.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help