Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] grep: simple test for operation in a bare repository

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:48:11

René Scharfe [off-list ref] writes:
This patch converts the setenv() calls in path.c and setup.c.  After
the call, git grep with a pager works again in bare repos.

It leaves the setenv(GIT_DIR_ENVIRONMENT, ...) calls in git.c alone, as
they respond to command line switches that emulate the effect of setting
the environment variable directly.

The remaining site in environment.c is in set_git_dir() and is left
alone, too, of course.  Finally, builtin-init-db.c is left changed
because the repo is still being carefully constructed when the
environment variable is set.
Thanks for a thorough analysis.  The patch looks correct and I am very
tempted to put it into 1.7.0, though I'd stop at queuing it to 'next'.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help