Re: [PATCH v6] add --summary option to git-push and git-fetch

On Fri, 29 Jan 2010, Junio C Hamano wrote:

As I said in my review during the earlier rounds, I do not know if it is
safe to use the flags and do the traversal inside this same process.  You
may be clearing the flags to protect your traversal (one per branch) from
stepping on each other, but how would this affect the use of object flags
in existing parts of the "push" machinery?  Is the reasoning that even if
push calls into traversal code and after it walked the commit ancestry for
its own purpose, your addition will clear the flags and existing code will
never look at object flags again, so this new code is free to use them and
all is Ok?  As long as you made sure that nobody looks at object flags you
modified, then I am fine with that---I just don't know if that is what is
happening here, and that is why I am asking.

I'd need help from the usual "transport" suspects for this patch.

I'm pretty sure that the built-in transport implementations all clear the 
flags themselves before using them. The fetch side has to be able to fetch 
twice in order to handle tags, and the push side has to be able to push to 
multiple destinations. So both parts should be defending themselves 
against flags that are specificly confusing to that part.

	-Daniel
*This .sig left intentionally blank*