Re: [PATCH 12/12] Teach Makefile to check header dependencies
From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:48:08
Possibly related (same subject, not in this thread)
- 2016-06-15 · Re: [PATCH 12/12] Teach Makefile to check header dependencies · Junio C Hamano <hidden>
- 2016-06-15 · [PATCH 12/12] Teach Makefile to check header dependencies · Jonathan Nieder <hidden>
Junio C Hamano wrote:
Thanks. Three observations: * "make distclean" should remove $(dep_files);
It removes $(dep_dirs) in "make clean". Do you think they should be kept around? Or is this about when COMPUTE_HEADER_DEPENDENCIES is turned off but .o.d files remain?
* "deps/" should probably be ".depend/" or something less distracting;
Good idea.
* I wish CHECK_HEADER_DEPENDENCIES pointed out unnecessary dependencies hardcoded in the Makefile.
That would not be hard to do, but wouldn’t the $(GIT_OBJS): $(LIB_H) rule create a lot of noise? How about if it checks for duplicate dependencies and unnecessary dependencies that are not in LIB_H?
quoted hunk ↗ jump to hunk
-- >8 -- Subject: [PATCH] Makefile: "make distclean" should remove dependency files Signed-off-by: Junio C Hamano <redacted> --- Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)diff --git a/Makefile b/Makefile index 45b1f54..8578b31 100644 --- a/Makefile +++ b/Makefile@@ -2110,7 +2110,7 @@ dist-doc: ### Cleaning rules distclean: clean - $(RM) configure + $(RM) configure $(dep_files)
This couldn’t hurt, but I wonder whether it is necessary; see above. Thanks for the feedback, Jonathan