Re: [PATCH] Do not install shell libraries executable
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:48:08
Possibly related (same subject, not in this thread)
- 2016-06-15 · [PATCH] Do not install shell libraries executable · Jonathan Nieder <hidden>
Jonathan Nieder [off-list ref] writes:
quoted hunk
@@ -1488,6 +1490,15 @@ $(patsubst %.sh,%,$(SCRIPT_SH)) : % : %.sh chmod +x $@+ && \ mv $@+ $@ +$(patsubst %.sh,%,$(SCRIPT_LIB_SH)) : % : %.sh + $(QUIET_GEN)$(RM) $@ $@+ && \ + sed -e 's|@SHELL_PATH@|$(SHELL_PATH_SQ)|' \ + -e 's/@@GIT_VERSION@@/$(GIT_VERSION)/g' \ + -e 's/@@NO_CURL@@/$(NO_CURL)/g' \ + -e $(BROKEN_PATH_FIX) \ + $@.sh >$@+ && \ + mv $@+ $@ +
Can't you do something about this repetition from existing $(SCRIPT_SH) munging? Other than that the patch looks like Ok.