Thread (6 messages) 6 messages, 3 authors, 2016-06-15

Re: [PATCH v2] Windows: improve performance by avoiding a static dependency on ws2_32.dll and advapi32.dll

flat view

From: Johannes Sixt <hidden>
Date: 2016-06-15 22:48:07

Michael Lukashov schrieb:
ws2_32.dll is used by limited subset of git commands, such as pull,
push, fetch, send-email, ... By looking up functions that we need
at runtime, we can avoid the startup costs of this DLL.
As a result, we can remove static dependency on advapi32.dll too.

A call to "git status" loaded

before:  8 DLL
after:   4 DLL
Thanks. Due to the size of the change, I would acknowledge it only if you
have a proof that the reduced startup costs are noticable, for example, by
running the test suite.

What's the deal with bswap? Isn't it an unrelated change? It needs some
better justification. It is unobvious because it is not straight-forward
"use pointer to function that was looked up instead of function".

Will the result not break the MSVC build?

-- Hannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help